[
https://issues.apache.org/jira/browse/BEAM-7909?focusedWorklogId=297623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297623
]
ASF GitHub Bot logged work on BEAM-7909:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 05:29
Start Date: 20/Aug/19 05:29
Worklog Time Spent: 10m
Work Description: yifanzou commented on pull request #9351: [BEAM-7909]
support customized container for Python
URL: https://github.com/apache/beam/pull/9351#discussion_r315511451
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -84,16 +84,10 @@ def __init__(self):
@staticmethod
def default_docker_image():
if 'USER' in os.environ:
- if sys.version_info[0] == 2:
- version_suffix = ''
- elif sys.version_info[0:2] == (3, 5):
- version_suffix = '3'
- else:
- version_suffix = '3'
- # TODO(BEAM-7474): Use an image which has correct Python minor version.
- logging.warning('Make sure that locally built Python SDK docker image '
- 'has Python %d.%d interpreter. See also: BEAM-7474.' %
(
- sys.version_info[0], sys.version_info[1]))
+ version_suffix = ''.join([str(i) for i in sys.version_info[0:2]])
Review comment:
+1 with Ahmet for not skipping these tests. But, failing a test which
because of the user didn't build images beforehand does not make sense to me.
Could we add warnings in the tests if the default images are missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 297623)
Time Spent: 3h 50m (was: 3h 40m)
> Write integration tests to test customized containers
> -----------------------------------------------------
>
> Key: BEAM-7909
> URL: https://issues.apache.org/jira/browse/BEAM-7909
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
