[
https://issues.apache.org/jira/browse/BEAM-7264?focusedWorklogId=297858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297858
]
ASF GitHub Bot logged work on BEAM-7264:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 13:19
Start Date: 20/Aug/19 13:19
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #9373: [BEAM-7264] Remove
set/getClientConfiguration in JdbcIO
URL: https://github.com/apache/beam/pull/9373#issuecomment-523010991
Ok I see what you mean now (thanks for the clarification), If I understood
correctly, what you mean is to make the methods exclusive. If so, yes, it could
be good for user friendliness. Only thing that it is not clear to me is `the
order of creating them is undetermined` I think it is deterministic to the
latest method call the user does of the two (internal attribute will be
overwritten).
I am not 100% sure if the improvement is worth, currently users can also
call `withDataSourceConfiguration` with some configuration and then
`withDataSourceConfiguration` with a different configuration and we do not
validate this. I am weary of the extra complexity for not much in return and
the fact of differing of how other IOs with similar APIs work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 297858)
Time Spent: 1h (was: 50m)
> Remove set/getClientConfiguration in JdbcIO
> -------------------------------------------
>
> Key: BEAM-7264
> URL: https://issues.apache.org/jira/browse/BEAM-7264
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Labels: backwards-incompatible
> Fix For: 2.16.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> BEAM-7263 deprecated these methods and now they can be removed.
> This is a minor clean up to remove the two methods because they are not used
> internally anymore, the `ClientConfiguration` object is now wrapped and
> passed as a function to `withDataSourceProviderFn`. This has almost zero
> impact on end users because the set functionality is already covered by the
> `with` method and the `get` method is not mandatory because the user already
> has the reference.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
