[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=298000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298000 ]
ASF GitHub Bot logged work on BEAM-1009: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Aug/19 16:15 Start Date: 20/Aug/19 16:15 Worklog Time Spent: 10m Work Description: kennknowles commented on pull request #9338: [BEAM-1009] Upgrade to Mockito 3 URL: https://github.com/apache/beam/pull/9338#discussion_r315780435 ########## File path: runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/util/common/worker/WorkProgressUpdaterTest.java ########## @@ -165,8 +165,7 @@ public void updatesBeforePeriodicCheckpoint() throws Exception { // Set the initial lease expiration to 20s so that the first update occurs at 10s, ie before // the periodic checkpoint. initialLeaseExpirationMs = clock.currentTimeMillis() + 20 * 1000L; - when(progressHelper.reportProgress(any(NativeReader.DynamicSplitResult.class))) - .thenReturn(4 * 1000L); // Next update at 14s. + when(progressHelper.reportProgress(null)).thenReturn(4 * 1000L); // Next update at 14s. Review comment: Got it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 298000) > Upgrade to Mockito 3 > -------------------- > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core > Reporter: Pei He > Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian Jira (v8.3.2#803003)