[
https://issues.apache.org/jira/browse/BEAM-8006?focusedWorklogId=298134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298134
]
ASF GitHub Bot logged work on BEAM-8006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 20:05
Start Date: 20/Aug/19 20:05
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9375: [BEAM-8006]
Add retracting to windowing strategy translation.
URL: https://github.com/apache/beam/pull/9375#discussion_r315878718
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowingStrategy.java
##########
@@ -47,7 +47,8 @@
/** The accumulation modes that can be used with windowing. */
public enum AccumulationMode {
DISCARDING_FIRED_PANES,
- ACCUMULATING_FIRED_PANES
+ ACCUMULATING_FIRED_PANES,
+ RETRACTING_FIRED_PANES,
Review comment:
Thanks @lukecwik. I am not sure if I followed the best practice, but I add
`@Experimental` annotation, add a comment and also add to javadoc about
experimental information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 298134)
Time Spent: 1h (was: 50m)
> add retracting to windowing strategy translation
> ------------------------------------------------
>
> Key: BEAM-8006
> URL: https://issues.apache.org/jira/browse/BEAM-8006
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
