[
https://issues.apache.org/jira/browse/BEAM-7969?focusedWorklogId=298895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298895
]
ASF GitHub Bot logged work on BEAM-7969:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/19 18:38
Start Date: 21/Aug/19 18:38
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #9330: [BEAM-7969]
Report FnAPI counters as deltas in streaming jobs.
URL: https://github.com/apache/beam/pull/9330#discussion_r316341477
##########
File path:
sdks/python/apache_beam/runners/dataflow/dataflow_exercise_streaming_metrics_pipeline.py
##########
@@ -0,0 +1,100 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""A word-counting workflow."""
+
+from __future__ import absolute_import
+
+import argparse
+import logging
+import time
+
+import apache_beam as beam
+from apache_beam.metrics import Metrics
+from apache_beam.options.pipeline_options import PipelineOptions
+from apache_beam.options.pipeline_options import SetupOptions
+from apache_beam.options.pipeline_options import StandardOptions
+
+SLEEP_TIME_SECS = 1
+
+
+class StreamingUserMetricsDoFn(beam.DoFn):
+ """Generates several user metric counters."""
+
+ def __init__(self):
+ self.double_message_counter = Metrics.counter(self.__class__,
+ 'double_msg_counter_name')
+ self.msg_len_dist_metric = Metrics.distribution(
+ self.__class__, 'msg_len_dist_metric_name')
+
+ def start_bundle(self):
+ time.sleep(SLEEP_TIME_SECS)
+
+ def process(self, element):
+ """Returns the processed element and increments the metrics."""
+
+ text_line = element.strip()
+
+ self.double_message_counter.inc()
+ self.double_message_counter.inc()
+ self.msg_len_dist_metric.update(len(text_line))
+
+ logging.debug("Done processing returning element array: '%s'", element)
+
+ return [element]
+
+ def finish_bundle(self):
+ time.sleep(SLEEP_TIME_SECS)
+
+
+def run(argv=None):
+ """Given an initialized Pipeline applies transforms and runs it."""
+
+ parser = argparse.ArgumentParser()
+ parser.add_argument(
+ '--output_topic', required=True,
+ help=('Output PubSub topic of the form '
+ '"projects/<PROJECT>/topic/<TOPIC>".'))
+ group = parser.add_mutually_exclusive_group(required=True)
+ group.add_argument(
+ '--input_topic',
+ help=('Input PubSub topic of the form '
+ '"projects/<PROJECT>/topics/<TOPIC>".'))
+ group.add_argument(
+ '--input_subscription',
+ help=('Input PubSub subscription of the form '
+ '"projects/<PROJECT>/subscriptions/<SUBSCRIPTION>."'))
+ known_args, pipeline_args = parser.parse_known_args(argv)
+
+ pipeline_options = PipelineOptions(pipeline_args)
+ pipeline_options.view_as(SetupOptions).save_main_session = True
+ pipeline_options.view_as(StandardOptions).streaming = True
+ pipeline = beam.Pipeline(options=pipeline_options)
+
+ _ = (pipeline
Review comment:
Reading from files requires side inputs that is not properly supported in
FnApi streaming and causes existing pipeline to fail. Reusing your existing
pipeline was the first thing I tried to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 298895)
Time Spent: 4h 10m (was: 4h)
> Streaming Dataflow worker doesn't report FnAPI metrics.
> -------------------------------------------------------
>
> Key: BEAM-7969
> URL: https://issues.apache.org/jira/browse/BEAM-7969
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution, runner-dataflow
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> EOM
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
