[
https://issues.apache.org/jira/browse/BEAM-7980?focusedWorklogId=298982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298982
]
ASF GitHub Bot logged work on BEAM-7980:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/19 20:22
Start Date: 21/Aug/19 20:22
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9371: [BEAM-7980]
External environment with containerized worker pool
URL: https://github.com/apache/beam/pull/9371#discussion_r316384687
##########
File path: sdks/python/apache_beam/runners/worker/worker_pool_main.py
##########
@@ -0,0 +1,177 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+"""
+Worker pool entry point.
+
+The worker pool exposes an RPC service that is used with EXTERNAL
+environment to start and stop the SDK workers.
+
+The worker pool uses child processes for parallelism; threads are
Review comment:
It is a bit odd to read this here because `BeamFnExternalWorkerPoolServicer`
supports threads internally and tests make use of this feature. If this module
is the entry point for the worker pool, maybe the pooling code itself should be
located in a different module and we should only handle its configuration here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 298982)
Time Spent: 4h 20m (was: 4h 10m)
> External environment with containerized worker pool
> ---------------------------------------------------
>
> Key: BEAM-7980
> URL: https://issues.apache.org/jira/browse/BEAM-7980
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Augment Beam Python docker image and boot.go so that it can be used to launch
> BeamFnExternalWorkerPoolServicer.
> [https://docs.google.com/document/d/1z3LNrRtr8kkiFHonZ5JJM_L4NWNBBNcqRc_yAf6G0VI/edit#heading=h.lnhm75dhvhi0]
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
