[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=298986&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298986
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/19 20:25
Start Date: 21/Aug/19 20:25
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #9188:
[BEAM-7886] Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r316386018
##########
File path: sdks/python/setup.py
##########
@@ -115,8 +115,7 @@ def get_version():
'mock>=1.0.1,<3.0.0',
'pymongo>=3.8.0,<4.0.0',
'oauth2client>=2.0.1,<4',
- # grpcio 1.8.1 and above requires protobuf 3.5.0.post1.
- 'protobuf>=3.5.0.post1,<4',
+ 'protobuf>=3.8.0.post1,<4',
Review comment:
I bumped it because I used a 3.8.0 feature without realizing it (using
`schema_pb2.AtomicType.STRING`, rather than `schema_pb2.STRING`). This is
actually the bug I was referencing in
https://lists.apache.org/thread.html/e174967bab6c224db40f66af74e7d07466812cc6b78189e55da88cb0@%3Cdev.beam.apache.org%3E
If it's going to be a problem I can change it to back and update my code,
bumping it to 3.8.0 was just the lazy fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 298986)
Time Spent: 5.5h (was: 5h 20m)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
