[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=299101&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299101
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/19 01:01
Start Date: 22/Aug/19 01:01
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9188: [BEAM-7886]
Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r316460412
##########
File path: sdks/python/setup.py
##########
@@ -115,8 +115,7 @@ def get_version():
'mock>=1.0.1,<3.0.0',
'pymongo>=3.8.0,<4.0.0',
'oauth2client>=2.0.1,<4',
- # grpcio 1.8.1 and above requires protobuf 3.5.0.post1.
- 'protobuf>=3.5.0.post1,<4',
+ 'protobuf>=3.8.0.post1,<4',
Review comment:
Re: numpy
That is ok. It needs to be an explicit dependency at this point really.
you can remove numpy dependency under test packages and please try to keep
the same range.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 299101)
Time Spent: 7h 50m (was: 7h 40m)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
