[ https://issues.apache.org/jira/browse/BEAM-7642?focusedWorklogId=299106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299106 ]
ASF GitHub Bot logged work on BEAM-7642: ---------------------------------------- Author: ASF GitHub Bot Created on: 22/Aug/19 01:30 Start Date: 22/Aug/19 01:30 Worklog Time Spent: 10m Work Description: angoenka commented on pull request #9397: [BEAM-7642] Fix python sdk AfterProcessingTime unit discrepancy URL: https://github.com/apache/beam/pull/9397#discussion_r316464552 ########## File path: sdks/python/apache_beam/transforms/trigger.py ########## @@ -337,12 +337,12 @@ def from_runner_api(proto, context): proto.after_processing_time .timestamp_transforms[0] .delay - .delay_millis)) + .delay_millis) // 1000) Review comment: We should change line 317 to ` '', TimeDomain.REAL_TIME, context.get_current_time() + self.delay * 1000) ` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 299106) Time Spent: 0.5h (was: 20m) > (Dataflow) Python AfterProcessingTime fires before defined time > --------------------------------------------------------------- > > Key: BEAM-7642 > URL: https://issues.apache.org/jira/browse/BEAM-7642 > Project: Beam > Issue Type: Bug > Components: sdk-py-core > Reporter: Mikhail Gryzykhin > Assignee: Yichi Zhang > Priority: Major > Fix For: 2.16.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://stackoverflow.com/questions/56700913/why-my-data-in-apache-beam-is-emitted-after-a-few-minutes-instead-of-10h] > > User on StackOverflow has a problem that AfterProcessingTime on global window > fires before allocated time (10h). It dumps events within first > minutes/seconds and then drops the rest due to window closed. > Code user provided seems valid. I tried to verify time units accepted by the > method, but I couldn't track it all the way through the code. -- This message was sent by Atlassian Jira (v8.3.2#803003)