[ 
https://issues.apache.org/jira/browse/BEAM-7616?focusedWorklogId=299614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299614
 ]

ASF GitHub Bot logged work on BEAM-7616:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Aug/19 18:01
            Start Date: 22/Aug/19 18:01
    Worklog Time Spent: 10m 
      Work Description: udim commented on pull request #9401: [BEAM-7616] 
apitools use urllib with the global timeout. Set it to 60 seconds # to prevent 
network related stuckness issues.
URL: https://github.com/apache/beam/pull/9401#discussion_r316813169
 
 

 ##########
 File path: sdks/python/apache_beam/internal/gcp/auth.py
 ##########
 @@ -32,6 +33,10 @@
 except ImportError:
   GceAssertionCredentials = None
 
+# apitools use urllib with the global timeout. Set it to 60 seconds
+# to prevent network related stuckness issues.
+socket.setdefaulttimeout(60)
+  
 
 Review comment:
   The unknown part here is whether this gets applied on a remote worker. The 
defaulttimeout variable is a CPython implementation detail, so I don't believe 
it gets pickled and passed to workers. Will this module get imported on 
workers, or will the pickled version of it be used (such as with 
save_main_session)?
   
   My notes are here:
   
https://issues.apache.org/jira/browse/BEAM-7616?focusedCommentId=16913549&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16913549
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 299614)
    Time Spent: 2.5h  (was: 2h 20m)

> urlopen calls could get stuck without a timeout
> -----------------------------------------------
>
>                 Key: BEAM-7616
>                 URL: https://issues.apache.org/jira/browse/BEAM-7616
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Ahmet Altay
>            Assignee: Udi Meiri
>            Priority: Blocker
>             Fix For: 2.14.0, 2.16.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to