[ 
https://issues.apache.org/jira/browse/BEAM-7980?focusedWorklogId=299625&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299625
 ]

ASF GitHub Bot logged work on BEAM-7980:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Aug/19 18:20
            Start Date: 22/Aug/19 18:20
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on pull request #9398: [BEAM-7980] 
Exactly once artifact retrieval for Python SDK worker pool
URL: https://github.com/apache/beam/pull/9398#discussion_r316818691
 
 

 ##########
 File path: sdks/python/container/boot.go
 ##########
 @@ -33,6 +34,7 @@ import (
        "github.com/apache/beam/sdks/go/pkg/beam/util/execx"
        "github.com/apache/beam/sdks/go/pkg/beam/util/grpcx"
        "github.com/golang/protobuf/proto"
+       "github.com/nightlyone/lockfile"
 
 Review comment:
   About the same way as any other package: looking at the code. There's no 
good third party vetting system for Go at the moment.
   
   As for this one, it's a small package, (~200 lines), and only imports from 
the standard library, making it relatively safe, and easy to inspect.
   https://github.com/nightlyone/lockfile/blob/master/lockfile.go
   
   You can also get a view of other open source imported from godoc.org
   https://godoc.org/github.com/nightlyone/lockfile?importers
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 299625)
    Time Spent: 6h 50m  (was: 6h 40m)

> External environment with containerized worker pool
> ---------------------------------------------------
>
>                 Key: BEAM-7980
>                 URL: https://issues.apache.org/jira/browse/BEAM-7980
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-harness
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Major
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> Augment Beam Python docker image and boot.go so that it can be used to launch 
> BeamFnExternalWorkerPoolServicer.
> [https://docs.google.com/document/d/1z3LNrRtr8kkiFHonZ5JJM_L4NWNBBNcqRc_yAf6G0VI/edit#heading=h.lnhm75dhvhi0]
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to