[
https://issues.apache.org/jira/browse/BEAM-7872?focusedWorklogId=300259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300259
]
ASF GitHub Bot logged work on BEAM-7872:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/19 12:37
Start Date: 23/Aug/19 12:37
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9213: [BEAM-7872]
Simpler Flink cluster set up in load tests
URL: https://github.com/apache/beam/pull/9213#discussion_r317093314
##########
File path: .test-infra/jenkins/job_LoadTests_Combine_Flink_Python.groovy
##########
@@ -35,7 +35,7 @@ def scenarios = { datasetName -> [
jobProperties: [
job_name :
'load-tests-python-flink-batch-combine-1-' + now,
project : 'apache-beam-testing',
- publish_to_big_query: true,
Review comment:
I'd also love to have a commit description message showing why the change is
there. You could for example write something like this:
```
Metrics won't be published now because there is currently
no way to get metrics from PortableRunner's pipeline result
<here you add the issue link>.
We can activate this once collecting metrics is possible.
```
If you think that you can write an even better message feel free to do so! :)
Once you provide such message, future contributors will know exactly why
this code is as it is and change it depending on the state of PortableRunner.
Notice that no one will have to presume anything or dig into code - the commit
description will say it all after they use git blame. This is a huge benefit! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 300259)
Time Spent: 10h (was: 9h 50m)
> Simpler Flink cluster set up in load tests
> ------------------------------------------
>
> Key: BEAM-7872
> URL: https://issues.apache.org/jira/browse/BEAM-7872
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kamil Wasilewski
> Assignee: Kamil Wasilewski
> Priority: Major
> Time Spent: 10h
> Remaining Estimate: 0h
>
> Creating a new load test running on Flink runner could be easier by providing
> a single `setUp` function which would encapsulate the process of creating
> Flink cluster and registering teardown steps
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
