[ 
https://issues.apache.org/jira/browse/BEAM-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914519#comment-16914519
 ] 

Rui Wang edited comment on BEAM-6114 at 8/23/19 6:04 PM:
---------------------------------------------------------

Sorry Rahul. I must have thought something else when replied you last night.

Regarding to SideInputLookupJoin, I am thinking to separate boundness on 
non-seekable side.

For seekable join bounded: all types should be supported because you will see 
all data (which also means emitting once).
For seekable join unbounded: same as side input join.


In the future when we support retractions, we could support outer joins on the 
seekable side as we can retract results(but it might be less piratical to do so)
 


was (Author: amaliujia):
Sorry Rahul. I must have thought something else when replied you last night.

Regarding to SideInputLookupJoin, I am thinking to separate boundness on 
non-seekable side.

For seekable join bounded: all types should be supported because you will see 
all data (which also means emitting once).
For seekable join unbounded: same as side input join.
 

> SQL join selection should be done in planner, not in expansion to PTransform
> ----------------------------------------------------------------------------
>
>                 Key: BEAM-6114
>                 URL: https://issues.apache.org/jira/browse/BEAM-6114
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Kenneth Knowles
>            Assignee: Rahul Patwari
>            Priority: Major
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Currently Beam SQL joins all go through a single physical operator which has 
> a single PTransform that does all join algorithms based on properties of its 
> input PCollections as well as the relational algebra.
> A first step is to make the needed information part of the relational 
> algebra, so it can choose a PTransform based on that, and the PTransforms can 
> be simpler.
> Second step is to have separate (physical) relational operators for different 
> join algorithms.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to