[
https://issues.apache.org/jira/browse/BEAM-8014?focusedWorklogId=300551&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300551
]
ASF GitHub Bot logged work on BEAM-8014:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/19 22:26
Start Date: 23/Aug/19 22:26
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9376: [BEAM-8014]
Using OffsetRange as restriction for OffsetRestrictionTracker
URL: https://github.com/apache/beam/pull/9376#discussion_r317319851
##########
File path: sdks/python/apache_beam/io/restriction_trackers.py
##########
@@ -171,7 +175,7 @@ def checkpoint(self):
else:
end_position = self._current_position + 1
- residual_range = (end_position, self._range.stop)
+ residual_range = OffsetRange(end_position, self._range.stop)
Review comment:
In which case this could be
`self._range, residual_range = self._range.split(end_position)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 300551)
Time Spent: 0.5h (was: 20m)
> Use OffsetRange as restriction for OffsetRestrictionTracker
> -----------------------------------------------------------
>
> Key: BEAM-8014
> URL: https://issues.apache.org/jira/browse/BEAM-8014
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
