[ 
https://issues.apache.org/jira/browse/BEAM-8086?focusedWorklogId=300823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300823
 ]

ASF GitHub Bot logged work on BEAM-8086:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Aug/19 07:17
            Start Date: 25/Aug/19 07:17
    Worklog Time Spent: 10m 
      Work Description: je-ik commented on issue #9422: [BEAM-8086] add 
isRetraciton() to WindowedValue.
URL: https://github.com/apache/beam/pull/9422#issuecomment-524607425
 
 
   I think, that `PaneInfo` and `RetractionMode` (let's say) are orthogonal. It 
is imaginable (at least in theory), that at fully general level there will be 
early retraction firings. That can happen at least with early firings on 
merging windows, because every merge with previously (early) fired data will 
have to be retracted.
   I'd also suggest to convert the `boolean isRetraction()` to something 
returning and `enum`, because it is better extensible and is somehow more 
consistent with `PaneInfo`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 300823)
    Time Spent: 1h 10m  (was: 1h)

> Add isRetraction() to WindowedValue
> -----------------------------------
>
>                 Key: BEAM-8086
>                 URL: https://issues.apache.org/jira/browse/BEAM-8086
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to