[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=302513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302513
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Aug/19 03:46
Start Date: 28/Aug/19 03:46
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #9056: [BEAM-7746] Add
python type hints
URL: https://github.com/apache/beam/pull/9056#issuecomment-525572185
I just pushed a bunch of changes. I saw some updates to tickets related to
this on Jira, so I thought I'd give a little update.
This is a pretty big undertaking, and there are a lot of things in motion.
- I wrote pyi stubs for python-future, which was a tedious little side
escapade. I've [asked the author for
permission](https://github.com/PythonCharmers/python-future/issues/490) to add
them to the python typeshed. If he/she doesn't get back to me, I'll just make
a stub-only package and put it on pypi
- I made a [PR for mypy](https://github.com/python/mypy/pull/7210) to add
support for `future.utils.with_metaclass`, but it's waiting on the stubs to
find a home
- I've been [grappling with how to properly type the
callables](https://github.com/python/mypy/issues/7311) for DoFns. I'm not
satisfied with the options so might punt on that for now
- I'm waiting on the latest version of mypy to drop, which [adds official
error codes](https://github.com/python/mypy/pull/7334). I'll then need to
update mypy-runner to use these new error codes to do its filtering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 302513)
Time Spent: 7h 10m (was: 7h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)