[ 
https://issues.apache.org/jira/browse/BEAM-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919759#comment-16919759
 ] 

Daniel Oliveira commented on BEAM-8096:
---------------------------------------

The change looks good to me. You're right that there don't seem to be any tests 
for this yet. Feel free to make write the PR and add me or [~lostluck]  as a 
reviewer to it (I believe he'll be back sometime next week).

> Allow runner to configure "subnetwork"
> --------------------------------------
>
>                 Key: BEAM-8096
>                 URL: https://issues.apache.org/jira/browse/BEAM-8096
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>    Affects Versions: 2.15.0
>            Reporter: Jack Whelpton
>            Assignee: Robert Burke
>            Priority: Major
>
> When running a Dataflow job, the network can be specified using the --network 
> flag; however, there is no support for doing the same for the subnetwork. 
> This would be the go equivalent of the following Java code:
> [https://cloud.google.com/dataflow/java-sdk/JavaDoc/com/google/cloud/dataflow/sdk/options/DataflowPipelineWorkerPoolOptions.html#getSubnetwork--|https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L151]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to