[
https://issues.apache.org/jira/browse/BEAM-8113?focusedWorklogId=304527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304527
]
ASF GitHub Bot logged work on BEAM-8113:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/19 19:11
Start Date: 30/Aug/19 19:11
Worklog Time Spent: 10m
Work Description: je-ik commented on issue #9451: [BEAM-8113] Stage files
from context classloader
URL: https://github.com/apache/beam/pull/9451#issuecomment-526715671
Fair points, thanks. I thought this will be a "small enough" change, so that
it doesn't need any tests, but it is actually bigger. Regarding user specified
classpath - true. But then I'd say we should auto stage nothing. Currently it
already behaves the sometimes-things-work-sometimes-not-way. I'm fine with
dropping the autostaging, but that would be a breaking change. The current
state is not working on JDK9 and later, so we cannot keep it either.
That seems to give a conclusion, that this proposed change is "somewhat
better than current state", although not perfect. So, if I will add tests (I'm
a little tempted to put that into @ValidatesRunner, but I'm afraid, that it
would be much more work, than I previously planned to invest into this :-)),
will you then be fine with the proposed approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 304527)
Time Spent: 2h 20m (was: 2h 10m)
> FlinkRunner: Stage files from context classloader
> -------------------------------------------------
>
> Key: BEAM-8113
> URL: https://issues.apache.org/jira/browse/BEAM-8113
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Currently, only files from {{FlinkRunner.class.getClassLoader()}} are staged
> by default. Add also files from
> {{Thread.currentThread().getContextClassLoader()}}.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
