[
https://issues.apache.org/jira/browse/BEAM-8113?focusedWorklogId=305496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305496
]
ASF GitHub Bot logged work on BEAM-8113:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/19 09:34
Start Date: 03/Sep/19 09:34
Worklog Time Spent: 10m
Work Description: je-ik commented on issue #9451: [BEAM-8113] Stage files
from context classloader
URL: https://github.com/apache/beam/pull/9451#issuecomment-527382672
> Thanks for the changes @je-ik. It looks like this is centred around
context class loaders now. We should also support shipping required Beam
classes from other class loaders. The way this is currently laid out, we would
miss important classes, e.g. FlinkRunner which the remote Flink cluster does
not have.
Yes, agree that we need to ship these files. And they will be shipped, as
long as the classloader that loaded `FlinkRunner` is parent of current context
classloader. I agree that that might not be the case for 100% of cases
(although it seems to be weird, the JVM would be somewhat broken I'd say).
Nevertheless, I'll fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 305496)
Time Spent: 4.5h (was: 4h 20m)
> FlinkRunner: Stage files from context classloader
> -------------------------------------------------
>
> Key: BEAM-8113
> URL: https://issues.apache.org/jira/browse/BEAM-8113
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Currently, only files from {{FlinkRunner.class.getClassLoader()}} are staged
> by default. Add also files from
> {{Thread.currentThread().getContextClassLoader()}}.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
