[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=305934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305934
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/19 22:20
Start Date: 03/Sep/19 22:20
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9390: [BEAM-8019]
Several changes to support cross-language transforms on DataflowRunner
URL: https://github.com/apache/beam/pull/9390#discussion_r320501968
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -917,8 +917,20 @@ def is_side_input(tag):
for tag, id in proto.outputs.items()}
# This annotation is expected by some runners.
if proto.spec.urn == common_urns.primitives.PAR_DO.urn:
- result.transform.output_tags = set(proto.outputs.keys()).difference(
- {'None'})
+ # Some external transforms require output tags to be not to be modified.
+ # So we randomly select one of the output tags as the main output and
+ # leave others as side outputs. Transform execution should not change
Review comment:
Looking at the code some more, output_tags is only ever used by the dataflow
runner. Could we please isolate these workarounds there instead and simply
delete the output_tags attribute here (and also not introduce main_output_tag)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 305934)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Jayalath
> Assignee: Chamikara Jayalath
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
