[
https://issues.apache.org/jira/browse/BEAM-8151?focusedWorklogId=306689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-306689
]
ASF GitHub Bot logged work on BEAM-8151:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/19 20:16
Start Date: 04/Sep/19 20:16
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #9477: [BEAM-8151,
BEAM-7848] Up the max number of threads inside the SDK harness to a default of
10k
URL: https://github.com/apache/beam/pull/9477#discussion_r320953605
##########
File path: sdks/python/apache_beam/runners/portability/local_job_service.py
##########
@@ -73,7 +73,7 @@ def __init__(self, staging_dir=None):
self._artifact_staging_endpoint = None
def start_grpc_server(self, port=0):
- self._server = grpc.server(futures.ThreadPoolExecutor(max_workers=3))
+ self._server = grpc.server(CollapsingThreadPoolExecutor(max_workers=3))
Review comment:
3 is arbitrary, perhaps just omit the argument?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 306689)
Time Spent: 40m (was: 0.5h)
> Allow the Python SDK to use many many threads
> ---------------------------------------------
>
> Key: BEAM-8151
> URL: https://issues.apache.org/jira/browse/BEAM-8151
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core, sdk-py-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We need to use a thread pool which shrinks the number of active threads when
> they are not being used.
>
> This is to prevent any stuckness issues related to a runner scheduling more
> work items then there are "work" threads inside the SDK harness.
>
> By default the control plane should have all "requests" being processed in
> parallel and the runner is responsible for not overloading the SDK with too
> much work.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
