[
https://issues.apache.org/jira/browse/BEAM-7945?focusedWorklogId=307135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307135
]
ASF GitHub Bot logged work on BEAM-7945:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/19 13:14
Start Date: 05/Sep/19 13:14
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on pull request #9452:
[BEAM-7945] Allow runner to configure semi_persist_dir which is used …
URL: https://github.com/apache/beam/pull/9452#discussion_r321250359
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -815,6 +815,7 @@ message StartWorkerRequest {
org.apache.beam.model.pipeline.v1.ApiServiceDescriptor logging_endpoint = 3;
org.apache.beam.model.pipeline.v1.ApiServiceDescriptor artifact_endpoint = 4;
org.apache.beam.model.pipeline.v1.ApiServiceDescriptor provision_endpoint =
5;
+ string semi_persist_dir = 6;
Review comment:
Great to have your suggestions. :)
Maybe I have not understood your idea. If we configure the dir for the whole
pool, we
may loose the flexibility that different jobs may set different
semi_persist_dir for the workers in the same worker pool?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 307135)
Time Spent: 40m (was: 0.5h)
> Allow runner to configure "semi_persist_dir" which is used in the SDK harness
> -----------------------------------------------------------------------------
>
> Key: BEAM-7945
> URL: https://issues.apache.org/jira/browse/BEAM-7945
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution, sdk-go, sdk-java-core, sdk-py-core
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently "semi_persist_dir" is not configurable. This may become a problem
> in certain scenarios. For example, the default value of "semi_persist_dir" is
> "/tmp"
> ([https://github.com/apache/beam/blob/master/sdks/python/container/boot.go#L48])
> in Python SDK harness. When the environment type is "PROCESS", the disk of
> "/tmp" may be filled up and unexpected issues will occur in production
> environment. We should provide a way to configure "semi_persist_dir" in
> EnvironmentFactory at the runner side.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
