[
https://issues.apache.org/jira/browse/BEAM-7969?focusedWorklogId=308156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308156
]
ASF GitHub Bot logged work on BEAM-7969:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/19 20:54
Start Date: 06/Sep/19 20:54
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #9494: [BEAM-7969]
Fix doublecount on GRPC PCollections in streaming jobs.
URL: https://github.com/apache/beam/pull/9494#discussion_r321906748
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -400,13 +409,19 @@ void updateProgress() {
* @param monitoringInfos Usually received from FnApi.
*/
private void updateMetrics(List<MonitoringInfo> monitoringInfos) {
+ List<MonitoringInfo> monitoringInfosCopy = new
ArrayList<>(monitoringInfos);
+
+ List<MonitoringInfo> misToFilter =
+
bundleProcessOperation.findIOPCollectionMonitoringInfos(monitoringInfos);
Review comment:
Synced offline. I'll try to elaborate more on this.
When we modify graph for cross-boundary grpc operations, we give two
different PCollections same metadata. As a result we report metrics correctly
from SDK harness. Both of these PCollections generate metrics that show as
ElementCount metric on UI.
At this point, the shortest way to fix the issue is to utilize deduping on
runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 308156)
Time Spent: 6h 50m (was: 6h 40m)
> Streaming Dataflow worker doesn't report FnAPI metrics.
> -------------------------------------------------------
>
> Key: BEAM-7969
> URL: https://issues.apache.org/jira/browse/BEAM-7969
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution, runner-dataflow
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> EOM
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
