[
https://issues.apache.org/jira/browse/BEAM-5878?focusedWorklogId=308282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308282
]
ASF GitHub Bot logged work on BEAM-5878:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/19 03:33
Start Date: 07/Sep/19 03:33
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #9237: [BEAM-5878] support
DoFns with Keyword-only arguments
URL: https://github.com/apache/beam/pull/9237#issuecomment-529068152
One Beam SDK users who use master branch reported that monkey-patch caused
their pipeline to fail with what appears to be an infinite recursion from
new_save_reduce.
If line 163 is removed, the problem disappears. The problem persists with
the monkey patch, even if the body of new_save_reduce is changed to
```
StockPickler.save_reduce(self, func, args, *other_args, **kwargs)
```
@lazylynx I have not investigated that report yet but I'd suggest to revert
this change in the mean time until we understand a better way to patch, which
may not be necessary soon given your outstanding changes to dill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 308282)
Time Spent: 11h 10m (was: 11h)
> Support DoFns with Keyword-only arguments in Python 3.
> ------------------------------------------------------
>
> Key: BEAM-5878
> URL: https://issues.apache.org/jira/browse/BEAM-5878
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: yoshiki obata
> Priority: Minor
> Fix For: 2.16.0
>
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> Python 3.0 [adds a possibility|https://www.python.org/dev/peps/pep-3102/] to
> define functions with keyword-only arguments.
> Currently Beam does not handle them correctly. [~ruoyu] pointed out [one
> place|https://github.com/apache/beam/blob/a56ce43109c97c739fa08adca45528c41e3c925c/sdks/python/apache_beam/typehints/decorators.py#L118]
> in our codebase that we should fix: in Python in 3.0 inspect.getargspec()
> will fail on functions with keyword-only arguments, but a new method
> [inspect.getfullargspec()|https://docs.python.org/3/library/inspect.html#inspect.getfullargspec]
> supports them.
> There may be implications for our (best-effort) type-hints machinery.
> We should also add a Py3-only unit tests that covers DoFn's with keyword-only
> arguments once Beam Python 3 tests are in a good shape.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
