[
https://issues.apache.org/jira/browse/BEAM-8170?focusedWorklogId=309369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309369
]
ASF GitHub Bot logged work on BEAM-8170:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/19 23:31
Start Date: 09/Sep/19 23:31
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9522: [BEAM-8170]
Don't import PyArrow on Python 2 + Windows
URL: https://github.com/apache/beam/pull/9522#discussion_r322496545
##########
File path: sdks/python/apache_beam/testing/datatype_inference.py
##########
@@ -34,6 +35,9 @@
from avro.schema import parse as Parse # avro library for python2
# pylint: enable=wrong-import-order, wrong-import-position
+if not (platform.system() == 'Windows' and sys.version_info[0] == 2):
Review comment:
@tvalentyn is adding more cases where pyarrow is not supported. I will
suggest using the general pattern we use in other places with
try:
import ... as pa
except ImportError
pa = None
...
if not pa:
...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309369)
Time Spent: 0.5h (was: 20m)
> datatype_inference_test break windows tests
> -------------------------------------------
>
> Key: BEAM-8170
> URL: https://issues.apache.org/jira/browse/BEAM-8170
> Project: Beam
> Issue Type: Improvement
> Components: test-failures
> Affects Versions: 2.16.0
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Blocker
> Fix For: Not applicable
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> These tests were added in https://github.com/apache/beam/pull/9281/files
> Windows + Py2 doesn't not support pyarrow.
> Please avoid importing pyarrow in this test. Example:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/parquetio_test.py#L49-L58
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
