[
https://issues.apache.org/jira/browse/BEAM-8105?focusedWorklogId=310338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310338
]
ASF GitHub Bot logged work on BEAM-8105:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/19 06:37
Start Date: 11/Sep/19 06:37
Worklog Time Spent: 10m
Work Description: markflyhigh commented on pull request #9506:
[BEAM-8105] Docker images release scripts
URL: https://github.com/apache/beam/pull/9506#discussion_r323076674
##########
File path: release/src/main/scripts/publish_docker_images.sh
##########
@@ -0,0 +1,77 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# This script will generate and publish docker images for each language
version to Docker Hub:
+# 1. Generate images tagged with :{RELEASE}
+# 2. Publish images tagged with :{RELEASE}
+# 3. Tag images with :latest tag and publish.
+# 4. Clearn up images.
+
+set -e
+
+source release/src/main/scripts/build_release_candidate.sh
+
+echo "Publish SDK docker images to Docker Hub."
+echo "Do you want to proceed? [y|N]"
+read confirmation
+if [[ $confirmation = "y" ]]; then
+ echo "============Publishing SDK docker images on docker hub========="
+ cd ~
+ if [[ -d ${LOCAL_PYTHON_STAGING_DIR} ]]; then
+ rm -rf ${LOCAL_PYTHON_STAGING_DIR}
+ fi
+ mkdir -p ${LOCAL_PYTHON_STAGING_DIR}
+ cd ${LOCAL_PYTHON_STAGING_DIR}
+
+ echo '-------------------Cloning Beam Release Branch-----------------'
+ git clone ${GIT_REPO_URL}
+ cd ${BEAM_ROOT_DIR}
+ git checkout ${RELEASE_BRANCH}
+
+ echo '-------------------Generating and Pushing Python
images-----------------'
+ ./gradlew :sdks:python:container:buildAll -Pdocker-tag=${RELEASE}
Review comment:
This build steps lgtm in general. However, I'm wondering is it possible to
reuse existing staged rc image instead of building another one? Rerun gradle
build takes longer time and potentially has risk to introduce differences.
Probably docker pull + tag + push?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 310338)
Time Spent: 3h 50m (was: 3h 40m)
> Add container publishing instruction to release manual
> ------------------------------------------------------
>
> Key: BEAM-8105
> URL: https://issues.apache.org/jira/browse/BEAM-8105
> Project: Beam
> Issue Type: Sub-task
> Components: website
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
