[
https://issues.apache.org/jira/browse/BEAM-8204?focusedWorklogId=310970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310970
]
ASF GitHub Bot logged work on BEAM-8204:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/19 20:13
Start Date: 11/Sep/19 20:13
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #9541:
[BEAM-8204][BEAM-8205] Exclude AvroSchemaTest for Apex and Flink runner for now
URL: https://github.com/apache/beam/pull/9541#issuecomment-530546521
Technically I think Flink should not be relying on comparing coders. Beam
has never required Coder authors to implement a Java equals method, and
other runners don't do such Coder comparisons on flatten. However for now
we can disable the test on Flink.
On Wed, Sep 11, 2019 at 1:07 PM Brian Hulette <[email protected]>
wrote:
> +1 LGTM. I think @reuvenlax <https://github.com/reuvenlax> is right that
> #9446 <https://github.com/apache/beam/pull/9446>'s addition of
> SchemaCoder.equals may fix this, but it's not fully baked yet. I think we
> should just skip until we can get the equality check right and un-skip
> these.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/9541?email_source=notifications&email_token=AFAYJVJDFAZZIPKEDUFJP5DQJFFX7A5CNFSM4IVN4VMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PXNZA#issuecomment-530544356>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVORR3UE3KAPFPZHBWDQJFFX7ANCNFSM4IVN4VMA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 310970)
Time Spent: 1h 40m (was: 1.5h)
> Newly added Java ValidatesRunner tests failed on ApexRunner
> -----------------------------------------------------------
>
> Key: BEAM-8204
> URL: https://issues.apache.org/jira/browse/BEAM-8204
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, test-failures
> Reporter: Yueyang Qiu
> Assignee: Brian Hulette
> Priority: Major
> Labels: currently-failing
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Jenkins link:
> [https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/testReport/]
>
> Initial investigation:
> [https://github.com/apache/beam/pull/9454] and
> [https://github.com/apache/beam/pull/9372] added new ValidatesRunner tests.
> They have been tested on Dataflow runner, but are failing on Apex runner.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
