[
https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=311717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311717
]
ASF GitHub Bot logged work on BEAM-8164:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Sep/19 20:54
Start Date: 12/Sep/19 20:54
Worklog Time Spent: 10m
Work Description: ibzib commented on issue #9536: [BEAM-8164][website]
Correct document for building the python SDK ha…
URL: https://github.com/apache/beam/pull/9536#issuecomment-531002621
Hi Jincheng, sorry I did not see this PR before filing my own that partially
addressed some of these issues. A few thoughts:
- Removing the outdated instructions LGTM.
- We should use python 3 in all the relevant examples, as py2 will be
deprecated soon.
- In a couple of the runner examples, we are instructing users to use
loopback mode, which means building the docker containers is actually not
needed (I missed this in #9545 as well). So we can just remove that step.
Wherever we actually do use the docker environment (the default), we should
probably change it to loopback, because loopback mode is easier to use for
newcomers to Beam.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 311717)
Time Spent: 40m (was: 0.5h)
> Correct document for building the python SDK harness container
> --------------------------------------------------------------
>
> Key: BEAM-8164
> URL: https://issues.apache.org/jira/browse/BEAM-8164
> Project: Beam
> Issue Type: Bug
> Components: website
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the runner document, it is described that we can use the command:
> `./gradlew :sdks:python:container:docker`
> to Build the SDK harness container, see
> ([https://beam.apache.org/documentation/runners/flink/)].
> However, the docker config has been removed with the latest python3 docker
> related commit [1] the command would failed with the following error message.
> {code:java}
> > Task :sdks:python:container:docker FAILED
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':sdks:python:container:docker'.
> > name is a required docker configuration item.{code}
> I think we should also adapt the document with command: `./gradlew
> :sdks:python:container:py2:docker`? Or add the config when run
> `:sdks:python:container:docker` auto run all the python version docker?
>
> What do you think?
>
> [1]
> [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
