[
https://issues.apache.org/jira/browse/BEAM-7389?focusedWorklogId=311737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311737
]
ASF GitHub Bot logged work on BEAM-7389:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Sep/19 21:08
Start Date: 12/Sep/19 21:08
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9561: [BEAM-7389]
Generate notebook for filter
URL: https://github.com/apache/beam/pull/9561#discussion_r323949505
##########
File path: website/src/documentation/transforms/python/element-wise/filter.md
##########
@@ -78,18 +92,32 @@ We can also use lambda functions to simplify **Example 1**.
```py
{% github_sample
/apache/beam/blob/master/sdks/python/apache_beam/examples/snippets/transforms/element_wise/filter.py
tag:filter_lambda %}```
+{:.notebook-skip}
Output `PCollection` after `Filter`:
+{:.notebook-skip}
```
{% github_sample
/apache/beam/blob/master/sdks/python/apache_beam/examples/snippets/transforms/element_wise/filter_test.py
tag:perennials %}```
-<table>
+{:.notebook-skip}
+<table style="display: inline-block">
<td>
<a class="button" target="_blank"
-
href="https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/snippets/transforms/element_wise/filter.py";>
+ href="https://colab.research.google.com/github/{{ site.branch_repo
}}/examples/notebooks/documentation/transforms/python/element-wise/filter-py.ipynb">
Review comment:
We just recently added these snippets. Do we no longer need them? Is
notebooks replacing them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 311737)
Time Spent: 58h 50m (was: 58h 40m)
> Colab examples for element-wise transforms (Python)
> ---------------------------------------------------
>
> Key: BEAM-7389
> URL: https://issues.apache.org/jira/browse/BEAM-7389
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Rose Nguyen
> Assignee: David Cavazos
> Priority: Minor
> Time Spent: 58h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
