[
https://issues.apache.org/jira/browse/BEAM-8238?focusedWorklogId=312689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312689
]
ASF GitHub Bot logged work on BEAM-8238:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/19 17:15
Start Date: 15/Sep/19 17:15
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #9572: [BEAM-8238] Improve
python gen_protos script
URL: https://github.com/apache/beam/pull/9572#issuecomment-531583067
The combination of all these little problems was adding up to a lot of
additional dev/test time for me on short runs:
- orphaned pb2 file (leftover from when I was playing with the schema coders
branch) triggering rebuilds
- futurize running twice for each call to gen_protos
- gen_protos being called twice for sdist, without any printout of what was
going on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 312689)
Time Spent: 1h (was: 50m)
> Improve python gen_protos script
> --------------------------------
>
> Key: BEAM-8238
> URL: https://issues.apache.org/jira/browse/BEAM-8238
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Issues that need to be solved:
> - doesn't print output to shell when run during `python setup.py`
> - runs futurize twice when grcpio-tools is not present and needs to be
> installed
> - does not account for the case where there are more output files than .proto
> files (just keeps triggering out-of-date rebuilds due to timestamp of
> orphaned output file)
> - plus it would be nice for debugging if the script printed why it is
> regenerating pb2 files, because there are a number of possible reasons
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
