[
https://issues.apache.org/jira/browse/BEAM-8176?focusedWorklogId=313595&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313595
]
ASF GitHub Bot logged work on BEAM-8176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/19 10:12
Start Date: 17/Sep/19 10:12
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9520: [BEAM-8176]
Fix BigQuery Java test jobs
URL: https://github.com/apache/beam/pull/9520#discussion_r325081439
##########
File path: .test-infra/jenkins/job_PerformanceTests_BigQueryIO_Java.groovy
##########
@@ -16,102 +16,93 @@
* limitations under the License.
*/
-import CommonJobProperties as commonJobProperties
-import LoadTestsBuilder as loadTestsBuilder
+
+import CommonJobProperties as common
import PhraseTriggeringPostCommitBuilder
def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
-def bqioStreamTest = [
- title : 'BigQueryIO Streaming Performance Test Java 10 GB',
- itClass : 'org.apache.beam.sdk.bigqueryioperftests.BigQueryIOIT',
- runner : CommonTestProperties.Runner.DATAFLOW,
- jobProperties: [
- jobName :
'performance-tests-bqio-java-stream-10gb' + now,
- project : 'apache-beam-testing',
- tempLocation :
'gs://temp-storage-for-perf-tests/loadtests',
- tempRoot :
'gs://temp-storage-for-perf-tests/loadtests',
- writeMethod : 'STREAMING_INSERTS',
- publishToBigQuery : true,
- testBigQueryDataset : 'beam_performance',
- testBigQueryTable : 'bqio_write_10GB_java',
- metricsBigQueryDataset: 'beam_performance',
- metricsBigQueryTable : 'bqio_10GB_results_java_stream',
- sourceOptions : '\'{' +
- '"num_records": 10485760,' +
- '"key_size": 1,' +
- '"value_size": 1024}\'',
- maxNumWorkers : 5,
- numWorkers : 5,
- autoscalingAlgorithm : 'NONE', // Disable autoscale the
worker pool.
+def testJobs = [
+ [
+ title : 'BigQueryIO Streaming Performance Test Java 10
GB',
+ triggerPhrase: 'Run BigQueryIO Streaming Performance Test
Java',
+ jobName :
'beam_BiqQueryIO_Streaming_Performance_Test_Java',
+ itClass :
'org.apache.beam.sdk.bigqueryioperftests.BigQueryIOIT',
+ jobProperties: [
+ project : 'apache-beam-testing',
+ tempLocation :
'gs://temp-storage-for-perf-tests/loadtests',
+ tempRoot :
'gs://temp-storage-for-perf-tests/loadtests',
+ writeMethod : 'STREAMING_INSERTS',
+ testBigQueryDataset : 'beam_performance',
+ testBigQueryTable : 'bqio_write_10GB_java',
+ metricsBigQueryDataset: 'beam_performance',
+ metricsBigQueryTable :
'bqio_10GB_results_java_stream',
+ sourceOptions : """
+ {
+ \\\\"numRecords\\\\":
\\\\"10485760\\\\",
+ \\\\"keySizeBytes\\\\":
\\\\"1\\\\",
+ \\\\"valueSizeBytes\\\\":
\\\\"1024\\\\"
+ }
+ """.trim().replaceAll("\\s", ""),
+ runner : 'DataflowRunner',
+ maxNumWorkers : '5',
+ numWorkers : '5',
+ autoscalingAlgorithm : 'NONE', // Disable autoscale
the worker pool.
+ ]
+ ],
+ [
+ title : 'BigQueryIO Batch Performance Test Java 10 GB',
+ triggerPhrase: 'Run BigQueryIO Batch Performance Test Java',
+ jobName : 'beam_BiqQueryIO_Batch_Performance_Test_Java',
+ itClass :
'org.apache.beam.sdk.bigqueryioperftests.BigQueryIOIT',
+ jobProperties: [
+ project : 'apache-beam-testing',
+ tempLocation :
'gs://temp-storage-for-perf-tests/loadtests',
+ tempRoot :
'gs://temp-storage-for-perf-tests/loadtests',
+ writeMethod : 'FILE_LOADS',
+ testBigQueryDataset : 'beam_performance',
+ testBigQueryTable : 'bqio_write_10GB_java',
+ metricsBigQueryDataset: 'beam_performance',
+ metricsBigQueryTable : 'bqio_10GB_results_java_batch',
+ sourceOptions : """
+ {
+ \\\\"numRecords\\\\":
\\\\"10485760\\\\",
+ \\\\"keySizeBytes\\\\":
\\\\"1\\\\",
+ \\\\"valueSizeBytes\\\\":
\\\\"1024\\\\"
+ }
+ """.trim().replaceAll("\\s", ""),
+ runner : "DataflowRunner",
+ maxNumWorkers : '5',
+ numWorkers : '5',
+ autoscalingAlgorithm : 'NONE', // Disable autoscale
the worker pool.
+ ]
]
]
-def bqioBatchTest = [
- title : 'BigQueryIO Batch Performance Test Java 10 GB',
- itClass : 'org.apache.beam.sdk.bigqueryioperftests.BigQueryIOIT',
- runner : CommonTestProperties.Runner.DATAFLOW,
- jobProperties: [
- jobName :
'performance-tests-bqio-java-stream-10gb' + now,
- project : 'apache-beam-testing',
- tempLocation :
'gs://temp-storage-for-perf-tests/loadtests',
- tempRoot :
'gs://temp-storage-for-perf-tests/loadtests',
- writeMethod : 'FILE_LOADS',
- publishToBigQuery : true,
- testBigQueryDataset : 'beam_performance',
- testBigQueryTable : 'bqio_write_10GB_java',
- metricsBigQueryDataset: 'beam_performance',
- metricsBigQueryTable : 'bqio_10GB_results_java_batch',
- sourceOptions : '\'{' +
- '"num_records": 10485760,' +
- '"key_size": 1,' +
- '"value_size": 1024}\'',
- maxNumWorkers : 5,
- numWorkers : 5,
- autoscalingAlgorithm : 'NONE', // Disable autoscale the
worker pool.
- ]
-]
+testJobs.forEach { jobConfig -> createPostCommitJob(jobConfig)}
+
+private void createPostCommitJob(testJob) {
+ job(testJob.jobName) {
+ description(testJob.description)
+ common.setTopLevelMainJobProperties(delegate)
+ common.enablePhraseTriggeringFromPullRequest(delegate, testJob.title,
testJob.triggerPhrase)
+ common.setAutoJob(delegate, 'H */6 * * *')
+ publishers {
+ archiveJunit('**/build/test-results/**/*.xml')
+ }
+
+ String runner = "dataflow"
Review comment:
What do you think of inilining `runner` and `testTask` variables? they're
used only once
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 313595)
Time Spent: 5h 40m (was: 5.5h)
> Java BigQuery performance tests don't run
> -----------------------------------------
>
> Key: BEAM-8176
> URL: https://issues.apache.org/jira/browse/BEAM-8176
> Project: Beam
> Issue Type: Bug
> Components: testing
> Affects Versions: 2.15.0
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
