[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=313686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313686
]
ASF GitHub Bot logged work on BEAM-8021:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/19 13:01
Start Date: 17/Sep/19 13:01
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add
Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#issuecomment-532210056
@lukecwik I posted another round of fixes, more specifically:
- nexmark, test-utils and expansion-service are still published with a
proper atomaticModuleName. This comes from the devlist discussion.
- I changed the prefixes of module names such as `org.apache.beam.sdk...`
names to `org.apache.beam.sdks.java...`. I think we should still include the
sdk name in case we have different sdks in JVM languages (kotlin?, scala?). As
far as I understand, they will also require the automaticModuleName so it's
good to prevent possible future collisions.
Could you take a look again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 313686)
Time Spent: 7h 10m (was: 7h)
> Add Automatic-Module-Name headers for Beam Java modules
> --------------------------------------------------------
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Ismaël Mejía
> Assignee: Lukasz Gajowy
> Priority: Minor
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
