[ https://issues.apache.org/jira/browse/BEAM-8203?focusedWorklogId=314482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314482 ]
ASF GitHub Bot logged work on BEAM-8203: ---------------------------------------- Author: ASF GitHub Bot Created on: 18/Sep/19 17:00 Start Date: 18/Sep/19 17:00 Worklog Time Spent: 10m Work Description: bmv126 commented on pull request #9597: [BEAM-8203] Add support for AvroTable in SQL URL: https://github.com/apache/beam/pull/9597#discussion_r325788472 ########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/avro/GenericRecordWriteConverter.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.extensions.sql.meta.provider.avro; + +import com.google.auto.value.AutoValue; +import java.io.Serializable; +import org.apache.avro.generic.GenericRecord; +import org.apache.beam.sdk.coders.AvroCoder; +import org.apache.beam.sdk.schemas.Schema; +import org.apache.beam.sdk.schemas.utils.AvroUtils; +import org.apache.beam.sdk.transforms.DoFn; +import org.apache.beam.sdk.transforms.PTransform; +import org.apache.beam.sdk.transforms.ParDo; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.Row; + +/** A {@link PTransform} to convert {@link Row} to {@link GenericRecord}. */ +@AutoValue +public abstract class GenericRecordWriteConverter Review comment: In the package org.apache.beam.sdk.extensions.sql.meta.provider.parquet there is also a ReadConverter class but these are not specific to Parquet. I was thinking of a separate PR to move these converter classes to some other package. Can you let me know, what is the best place to move these classes ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 314482) Time Spent: 1.5h (was: 1h 20m) > Support AvroTable > ----------------- > > Key: BEAM-8203 > URL: https://issues.apache.org/jira/browse/BEAM-8203 > Project: Beam > Issue Type: New Feature > Components: dsl-sql > Reporter: Rui Wang > Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Similar to https://github.com/apache/beam/pull/9054, we can support table > with Avro format. -- This message was sent by Atlassian Jira (v8.3.4#803005)