[
https://issues.apache.org/jira/browse/BEAM-5440?focusedWorklogId=314520&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314520
]
ASF GitHub Bot logged work on BEAM-5440:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/19 17:47
Start Date: 18/Sep/19 17:47
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8982: [BEAM-5440] Pass
docker run options to SDK harness containers
URL: https://github.com/apache/beam/pull/8982#discussion_r325808709
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerEnvironmentFactory.java
##########
@@ -136,6 +138,10 @@ public RemoteEnvironment createEnvironment(Environment
environment) throws Excep
dockerArgsBuilder.add("--rm");
}
+ if (!dockerOptions.isEmpty()) {
+ dockerArgsBuilder.addAll(Arrays.asList(dockerOptions.split("\\s+")));
Review comment:
Sorry for the delay here. The JSON part here is only for configuration from
the SDK side, also called environment config. The Proto changes should remain
as-is.
It is ok to make this backwards-incompatible change now. For the next
release we will publish containers and then the environment config format
should be consistent. Also, the JSON structure will make it much easier to be
backwards-compatible in future versions. If you want to remain
backwards-compatibility, you could also check if we have a JSON string or not
and still support the old parsing, but IMHO not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 314520)
Time Spent: 2h 50m (was: 2h 40m)
> Add option to mount a directory inside SDK harness containers
> -------------------------------------------------------------
>
> Key: BEAM-5440
> URL: https://issues.apache.org/jira/browse/BEAM-5440
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution, sdk-java-core
> Reporter: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> While experimenting with the Python SDK locally, I found it inconvenient that
> I can't mount a host directory to the Docker containers, i.e. the input must
> already be in the container and the results of a Write remain inside the
> container. For local testing, users may want to mount a host directory.
> Since BEAM-5288 the {{Environment}} carries explicit environment information,
> we could a) add volume args to the {{DockerPayload}}, or b) provide a general
> Docker arguments field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
