[
https://issues.apache.org/jira/browse/BEAM-7629?focusedWorklogId=315146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315146
]
ASF GitHub Bot logged work on BEAM-7629:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/19 16:13
Start Date: 19/Sep/19 16:13
Worklog Time Spent: 10m
Work Description: lostluck commented on issue #8936: [BEAM-7629] Go SDK
additional Validation for DoFns
URL: https://github.com/apache/beam/pull/8936#issuecomment-533203159
Run Go Postcommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 315146)
Time Spent: 1.5h (was: 1h 20m)
> Improve DoFn method validation in core/graph/fn.go
> --------------------------------------------------
>
> Key: BEAM-7629
> URL: https://issues.apache.org/jira/browse/BEAM-7629
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Various improvements can be made to validating the signatures and type usages
> in DoFns. Some things that should probably be checked:
> * Check that StartBundle and FinishBundle contain any emit parameters andÂ
> side inputs present in ProcessElement
> * Check that any side inputs/emits have correctly matching types between
> Start/FinishBundle and ProcessElement
> * Check that parameters and return values for the various methods are valid
> (for ex. Teardown/Setup should have no params)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
