[
https://issues.apache.org/jira/browse/BEAM-8279?focusedWorklogId=315195&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315195
]
ASF GitHub Bot logged work on BEAM-8279:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/19 17:03
Start Date: 19/Sep/19 17:03
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9611: [BEAM-8279]
Disable IOTypeHints.from_callable
URL: https://github.com/apache/beam/pull/9611#discussion_r326284101
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -121,6 +121,8 @@ def foo((a, b)):
_ANY_VAR_POSITIONAL = typehints.Tuple[typehints.Any, ...]
_ANY_VAR_KEYWORD = typehints.Dict[typehints.Any, typehints.Any]
+# TODO(BEAM-8280): Remove this when from_callable is ready to be enabled.
+_enable_from_callable = False
Review comment:
Sorry I don't have time to make this change. I'll be away for 1.5 weeks
starting tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 315195)
Time Spent: 1h 10m (was: 1h)
> temporarily disable IOTypeHints.from_callable
> ---------------------------------------------
>
> Key: BEAM-8279
> URL: https://issues.apache.org/jira/browse/BEAM-8279
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Affects Versions: 2.16.0
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Blocker
> Fix For: 2.16.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Py3 annotations support is too buggy to be put into the 2.16 release, and
> there is no easy way to disable/enable via flags.
> PRs made to fix bugs discovered while testing internally the upcoming release:
> https://github.com/apache/beam/pull/9563 - converts python type hints to Beam
> internal
> https://github.com/apache/beam/pull/9602 - fixes 4-5 bugs
> Re-enable from_callable once is has been more thoroughly tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
