[
https://issues.apache.org/jira/browse/BEAM-8025?focusedWorklogId=316795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316795
]
ASF GitHub Bot logged work on BEAM-8025:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/19 16:33
Start Date: 23/Sep/19 16:33
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #9614:
[BEAM-8025] Avoid race condition in cluster cleanup and introduce cluster
creation retrial under load.
URL: https://github.com/apache/beam/pull/9614#discussion_r327198827
##########
File path:
sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -106,21 +110,25 @@
private static Cluster cluster;
private static Session session;
- @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new
TemporaryFolder();
+ private static final String TEMPORARY_FOLDER =
System.getProperty("java.io.tmpdir");
@Rule public transient TestPipeline pipeline = TestPipeline.create();
private static CassandraShutDownHook shutdownHook;
@BeforeClass
public static void beforeClass() throws Exception {
jmxPort = NetworkTestHelper.getAvailableLocalPort();
shutdownHook = new CassandraShutDownHook();
- // randomized port at startup
- String data = TEMPORARY_FOLDER.newFolder("embedded-cassandra",
"data").getPath();
- String commitLog = TEMPORARY_FOLDER.newFolder("embedded-cassandra",
"commit-log").getPath();
- String cdcRaw = TEMPORARY_FOLDER.newFolder("embedded-cassandra",
"cdc-raw").getPath();
- String hints = TEMPORARY_FOLDER.newFolder("embedded-cassandra",
"hints").getPath();
- String savedCache = TEMPORARY_FOLDER.newFolder("embedded-cassandra",
"saved-cache").getPath();
- cluster =
+ String data = TEMPORARY_FOLDER + "/embedded-cassandra/data";
Review comment:
Please, extract `TEMPORARY_FOLDER + "/embedded-cassandra/"` into another
const string since it appears in many other places in this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 316795)
Time Spent: 2h 50m (was: 2h 40m)
> Cassandra IO classMethod test is flaky
> --------------------------------------
>
> Key: BEAM-8025
> URL: https://issues.apache.org/jira/browse/BEAM-8025
> Project: Beam
> Issue Type: Bug
> Components: io-java-cassandra, test-failures
> Affects Versions: 2.16.0
> Reporter: Kyle Weaver
> Assignee: Etienne Chauchot
> Priority: Blocker
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The most recent runs of this test are failing:
> [https://builds.apache.org/job/beam_PreCommit_Java_Commit/7398/]
> [https://builds.apache.org/job/beam_PreCommit_Java_Commit/7399/console]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
