[ 
https://issues.apache.org/jira/browse/BEAM-8131?focusedWorklogId=317355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317355
 ]

ASF GitHub Bot logged work on BEAM-8131:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Sep/19 10:41
            Start Date: 24/Sep/19 10:41
    Worklog Time Spent: 10m 
      Work Description: lgajowy commented on pull request #9482: [BEAM-8131] 
Provide Kubernetes setup for Prometheus
URL: https://github.com/apache/beam/pull/9482#discussion_r327541616
 
 

 ##########
 File path: .test-infra/metrics/docker-compose.yml
 ##########
 @@ -86,9 +86,35 @@ services:
       - DB_DBNAME=beam_metrics
       - DB_DBUSERNAME=admin
       - DB_DBPWD=<PGPasswordHere>
+  prometheus:
 
 Review comment:
   If we're able to provide Kubernetes only configuration files and use it in 
beam infra and for local development, then I'm in favor of dropping 
docker-compose. Keeping both tools can be confusing and can encourage future 
maintainers to use docker-compose not only for local dev (which IMO should be 
avoided). 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 317355)
    Time Spent: 3h 40m  (was: 3.5h)

> Provide Kubernetes setup with Prometheus
> ----------------------------------------
>
>                 Key: BEAM-8131
>                 URL: https://issues.apache.org/jira/browse/BEAM-8131
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Kamil Wasilewski
>            Assignee: Kamil Wasilewski
>            Priority: Major
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to