[
https://issues.apache.org/jira/browse/BEAM-3845?focusedWorklogId=317764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317764
]
ASF GitHub Bot logged work on BEAM-3845:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/19 19:08
Start Date: 24/Sep/19 19:08
Worklog Time Spent: 10m
Work Description: alanmyrvold commented on issue #9613: [BEAM-3845]
Remove deprecated Class.newInstance() method usage
URL: https://github.com/apache/beam/pull/9613#issuecomment-534705212
The PostRelease_NightlySnapshot
<https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_PostRelease_NightlySnapshot.groovy>
runs :release:runJavaExamplesValidationTask
which I think exercises those scripts?
On Tue, Sep 24, 2019 at 8:33 AM Łukasz Gajowy <[email protected]>
wrote:
> @alanmyrvold <https://github.com/alanmyrvold> and @yifanzou
> <https://github.com/yifanzou> we noticed together with @iemejia
> <https://github.com/iemejia> that this class (TestScripts) is used only
> by the quickstart-java-*.groovy, starter-generation.groovy and
> mobilegaming-java-*.groovy scripts. The scripts (quickstart,
> mobilegaming...) in turn seem to be not used by any job or gradle task in
> Beam's repo, so I have a question: are the groovy scripts still used
> anywhere or will be used? Or is it a "dead code" and we should delete this?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/9613?email_source=notifications&email_token=ABKL4FQSE7DME3L6PK4SDP3QLIXMPA5CNFSM4IYLC4KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7OZBTY#issuecomment-534614223>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ABKL4FVGZW6XUGNHYP27SGLQLIXMPANCNFSM4IYLC4KA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 317764)
Time Spent: 50m (was: 40m)
> Avoid calling Class#newInstance
> -------------------------------
>
> Key: BEAM-3845
> URL: https://issues.apache.org/jira/browse/BEAM-3845
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Ted Yu
> Assignee: Lukasz Gajowy
> Priority: Minor
> Labels: triaged
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Class#newInstance is deprecated starting in Java 9 -
> https://bugs.openjdk.java.net/browse/JDK-6850612 - because it may throw
> undeclared checked exceptions.
> The suggested replacement is getDeclaredConstructor().newInstance(), which
> wraps the checked exceptions in InvocationException.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
