[ https://issues.apache.org/jira/browse/BEAM-8313?focusedWorklogId=318596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318596 ]
ASF GitHub Bot logged work on BEAM-8313: ---------------------------------------- Author: ASF GitHub Bot Created on: 25/Sep/19 20:53 Start Date: 25/Sep/19 20:53 Worklog Time Spent: 10m Work Description: lostluck commented on pull request #9663: [BEAM-8313] Rename certain proto fields to be consistent across fn/runner APIs URL: https://github.com/apache/beam/pull/9663#discussion_r328335568 ########## File path: runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/data/BeamFnDataGrpcServiceTest.java ########## @@ -284,8 +284,8 @@ public void testMultipleClientsSendMessagesAreDirectedToProperConsumers() throws return BeamFnApi.Elements.newBuilder() .addData( BeamFnApi.Elements.Data.newBuilder() - .setInstructionReference(id) - .setPtransformId(PTRANSFORM_ID) + .setInstructionId(id) + .setTransformId(PTRANSFORM_ID) Review comment: SGTM. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 318596) Time Spent: 50m (was: 40m) > Rename yyy_reference to yyy_id to be consistent across protos > ------------------------------------------------------------- > > Key: BEAM-8313 > URL: https://issues.apache.org/jira/browse/BEAM-8313 > Project: Beam > Issue Type: Sub-task > Components: beam-model > Reporter: Luke Cwik > Assignee: Luke Cwik > Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > This will replace: > * ptransform_id -> transform_id > * ptransform_reference -> transform_id > * instruction_reference -> instruction_id > * process_bundle_descriptor_reference -> process_bundle_descriptor_id > -- This message was sent by Atlassian Jira (v8.3.4#803005)