[
https://issues.apache.org/jira/browse/BEAM-7933?focusedWorklogId=319809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319809
]
ASF GitHub Bot logged work on BEAM-7933:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 20:50
Start Date: 27/Sep/19 20:50
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #9673: [BEAM-7933] Add
job server request timeout (default to 60 seconds)
URL: https://github.com/apache/beam/pull/9673#discussion_r329242301
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -141,23 +141,25 @@ def _create_environment(options):
payload=(portable_options.environment_config.encode('ascii')
if portable_options.environment_config else None))
- def default_job_server(self, options):
+ def default_job_server(self, portable_options):
Review comment:
why this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 319809)
Time Spent: 0.5h (was: 20m)
> Adding timeout to JobServer grpc calls
> --------------------------------------
>
> Key: BEAM-7933
> URL: https://issues.apache.org/jira/browse/BEAM-7933
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.14.0
> Reporter: Enrico Canzonieri
> Assignee: Enrico Canzonieri
> Priority: Minor
> Labels: portability
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> grpc calls to the JobServer from the Python SDK do not have timeouts. That
> means that the call to pipeline.run()could hang forever if the JobServer is
> not running (or failing to start).
> E.g.
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/portable_runner.py#L307]
> the call to Prepare() doesn't provide any timeout value and the same applies
> to other JobServer requests.
> As part of this ticket we could add a default timeout of 60 seconds as the
> default timeout for http client.
> Additionally, we could consider adding a --job-server-request-timeout to the
> [PortableOptions|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/options/pipeline_options.py#L805]
> class to be used in the JobServer interactions inside probable_runner.py.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
