[ 
https://issues.apache.org/jira/browse/BEAM-6829?focusedWorklogId=322052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322052
 ]

ASF GitHub Bot logged work on BEAM-6829:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Oct/19 16:55
            Start Date: 02/Oct/19 16:55
    Worklog Time Spent: 10m 
      Work Description: mxm commented on issue #8585: [BEAM-6829] Use transform 
name for metric namespace if none provided
URL: https://github.com/apache/beam/pull/8585#issuecomment-537584412
 
 
   @tweise I've revisited this problem and found two other important fixes in 
addition to the first commit:
   
   1. We also need to include PCollection-scoped metrics, e.g. num elements
   2. The metric reporting was doubled in ExecutableDoFnOperator. Once by the 
operator,
       once by the wrapping metrics operator.
   
   In my tests I could not find any duplicate metrics anymore. Plus, the 
scoping of the metrics is done correctly, whether it is user metrics, transform 
metrics, or pcollection metrics.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 322052)
    Time Spent: 2h 10m  (was: 2h)

> Duplicate metric warnings clutter log
> -------------------------------------
>
>                 Key: BEAM-6829
>                 URL: https://issues.apache.org/jira/browse/BEAM-6829
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>    Affects Versions: 2.11.0
>            Reporter: Thomas Weise
>            Assignee: Maximilian Michels
>            Priority: Major
>              Labels: portability
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Logs fill up quickly with these warnings: 
> {code:java}
> WARN org.apache.flink.metrics.MetricGroup - Name collision: Group already 
> contains a Metric with the name ...{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to