[ 
https://issues.apache.org/jira/browse/BEAM-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942972#comment-16942972
 ] 

Lukasz Gajowy commented on BEAM-5559:
-------------------------------------

I see.

Let me understand this better: we're using vendored guava everywhere possible 
so there's no conflict between those dependencies. Beam can freely use the 
vendored one without filling that the classpath with version that is 
conflicting with beam's dependencies. On the other hand, I noticed that we're 
forcing guava to be in version 20.0 
[here|https://github.com/apache/beam/blob/6551d0937ee31a8e310b63b222dbc750ec9331f8/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1240]
 globally, for all modules (along with other dependencies but only guava 
concerns me right now). 

Is forcing guava version necessary? What is the purpose (I'm not sure I 
understand)? Can we force guava in version 20.0 only when using modules that 
actually require this version? 

The last thing would actually be helpful in mitigating errorprone issue 
(BEAM-8319) - we could skip errorprone but only for modules that require 
guava:20.0. 

> Beam Dependency Update Request: com.google.guava:guava
> ------------------------------------------------------
>
>                 Key: BEAM-5559
>                 URL: https://issues.apache.org/jira/browse/BEAM-5559
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dependencies
>            Reporter: Beam JIRA Bot
>            Priority: Major
>             Fix For: 2.15.0
>
>
>  ------------------------- 2018-10-01 19:30:53.471497 
> -------------------------
>         Please consider upgrading the dependency com.google.guava:guava. 
>         The current version is 20.0. The latest version is 26.0-jre 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2018-10-08 12:18:05.174889 
> -------------------------
>         Please consider upgrading the dependency com.google.guava:guava. 
>         The current version is 20.0. The latest version is 26.0-jre 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-04-15 12:32:27.737694 
> -------------------------
>         Please consider upgrading the dependency com.google.guava:guava. 
>         The current version is 20.0. The latest version is 27.1-jre 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-04-22 12:10:18.539470 
> -------------------------
>         Please consider upgrading the dependency com.google.guava:guava. 
>         The current version is 20.0. The latest version is 27.1-jre 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to