[
https://issues.apache.org/jira/browse/BEAM-8334?focusedWorklogId=322133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322133
]
ASF GitHub Bot logged work on BEAM-8334:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/19 18:39
Start Date: 02/Oct/19 18:39
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9704: [BEAM-8334]
Expose Language Options for testing
URL: https://github.com/apache/beam/pull/9704#discussion_r330708770
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##########
@@ -84,15 +84,19 @@ static Builder withQueryParams(Map<String, Value> params) {
* resolution strategy set in the context.
*/
ResolvedStatement analyze(String sql) {
- AnalyzerOptions options = initAnalyzerOptions(builder.queryParams);
+ AnalyzerOptions options = initAnalyzerOptions();
+ for (Map.Entry<String, Value> entry : builder.queryParams.entrySet()) {
Review comment:
I agree that we should have a single place that performs common init of
AnalizerOptions and I think this change still achieves that goal. The query
parameters are only set in the analyze path, so I think it actually creates
more confusion to move it into a separate function. I have no strong opinions
and can add a function if you'd like one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 322133)
Time Spent: 40m (was: 0.5h)
> Expose Language Options for testing
> -----------------------------------
>
> Key: BEAM-8334
> URL: https://issues.apache.org/jira/browse/BEAM-8334
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Trivial
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Google has a set of compliance tests for ZetaSQL. The test framework needs
> access to LanguageOptions to determine what tests are supported.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
