[
https://issues.apache.org/jira/browse/BEAM-8343?focusedWorklogId=323611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323611
]
ASF GitHub Bot logged work on BEAM-8343:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/19 17:45
Start Date: 04/Oct/19 17:45
Worklog Time Spent: 10m
Work Description: 11moon11 commented on issue #9718: [BEAM-8343] Moved
BeamTable classes to a more appropriate location
URL: https://github.com/apache/beam/pull/9718#issuecomment-538495582
> I think this should be broken up so the refactoring is separate from the
new features.
>
> PR 1:
>
> * Moved sql.BeamSqlTable → sql.meta.BeamSqlTable.
> * Renamed sql.imp.schema.BaseBeamTable →
sql.imp.schema.SchemaBaseBeamTable.
> * Created a sql.meta.BaseBeamTable to be a default implementation of
BeamSqlTable interface.
> * Updated existing IO Table classes to extend sql.meta.BaseBeamTable.
>
> PR 2:
>
> * Added methods needed for predicate/project push-down to BeamSqlTable
interface.
> * Create a sql.meta.BeamSqlTableFilter interface and a default
implementation for it sql.meta.DefaultTableFilter.
Makes sense, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 323611)
Time Spent: 1h 10m (was: 1h)
> Add means for IO APIs to support predicate and/or project push-down when
> running SQL pipelines
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-8343
> URL: https://issues.apache.org/jira/browse/BEAM-8343
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The objective is to create a universal way for Beam SQL IO APIs to support
> predicate/project push-down.
> A proposed way to achieve that is by introducing an interface responsible
> for identifying what portion(s) of a Calc can be moved down to IO layer.
> Also, adding following methods to a BeamSqlTable interface to pass necessary
> parameters to IO APIs:
> - BeamSqlTableFilter supportsFilter(RexProgram program, RexNode filter)
> - Boolean supportsProjects()
> - PCollection<Row> buildIOReader(PBegin begin, BeamSqlTableFilter filters,
> List<String> fieldNames)
>
> Design doc
> [link|https://docs.google.com/document/d/1-ysD7U7qF3MAmSfkbXZO_5PLJBevAL9bktlLCerd_jE/edit?usp=sharing].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
