[
https://issues.apache.org/jira/browse/BEAM-6947?focusedWorklogId=323974&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323974
]
ASF GitHub Bot logged work on BEAM-6947:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/19 20:14
Start Date: 05/Oct/19 20:14
Worklog Time Spent: 10m
Work Description: stale[bot] commented on issue #8180: [BEAM-6947] Fix
for failing TestGCSIO.test_last_updated (gcsio_test.py) test
URL: https://github.com/apache/beam/pull/8180#issuecomment-538684818
This pull request has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any
time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 323974)
Time Spent: 1h 20m (was: 1h 10m)
> TestGCSIO.test_last_updated (gcsio_test.py) fails when the current timezone
> offset and the timezone offset on 2nd of Jan 1970 differ
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-6947
> URL: https://issues.apache.org/jira/browse/BEAM-6947
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Csaba Kassai
> Assignee: Csaba Kassai
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The test TestGCSIO.test_last_updated uses timestamp 123456.78 as the last
> updated timestamp. This timestamp is converted into a naive datetime in the
> Fakefile class get_metadata method (gcsio_test.py line 72) Then in the GcsIO
> class last_updated method (gcsio.py ) is converted back to timestamp. But the
> conversion is incorrect when the the timezone offset is different in 1970 and
> now. In my case now Singapore is GMT+8 and it was only GMT+7:30 in 1970. So
> the test fails.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
