[
https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=325212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325212
]
ASF GitHub Bot logged work on BEAM-8362:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/19 17:52
Start Date: 08/Oct/19 17:52
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9739: [BEAM-8362]
Don't use ZetaSQL's unimplemented functions
URL: https://github.com/apache/beam/pull/9739#discussion_r332648960
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -517,13 +517,7 @@ public RexNode convertResolvedLiteral(ResolvedLiteral
resolvedLiteral) {
ret = convertValueToRexNode(resolvedLiteral.getType(),
resolvedLiteral.getValue());
break;
default:
- throw new RuntimeException(
- MessageFormat.format(
- "Unsupported ResolvedLiteral type: {0}, kind: {1}, value: {2},
class: {3}",
- resolvedLiteral.getType().typeName(),
- kind,
- resolvedLiteral.getValue(),
- resolvedLiteral.getClass()));
+ throw new RuntimeException("Unsupported ResolvedLiteral type.");
Review comment:
I would prefer a mixed approach:
1. give user the unsupported kind.
2. print log info of more information to help development.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 325212)
Time Spent: 1h (was: 50m)
> Don't use ZetaSQL's unimplemented functions
> -------------------------------------------
>
> Key: BEAM-8362
> URL: https://issues.apache.org/jira/browse/BEAM-8362
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Affects Versions: 2.15.0
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Unfortunately a bunch of debug functionality is still unimplemented in
> ZetaSQL. We should avoid calling those functions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
