[
https://issues.apache.org/jira/browse/BEAM-7730?focusedWorklogId=325604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325604
]
ASF GitHub Bot logged work on BEAM-7730:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/19 09:46
Start Date: 09/Oct/19 09:46
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9296: [BEAM-7730]
Introduce Flink 1.9 Runner
URL: https://github.com/apache/beam/pull/9296#discussion_r332898805
##########
File path:
runners/flink/1.5/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/io/BeamStoppableFunction.java
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.flink.translation.wrappers.streaming.io;
+
+import org.apache.flink.api.common.functions.StoppableFunction;
+
+/**
+ * Custom StoppableFunction for backward compatibility.
+ *
+ * @see <a
+ *
href="https://github.com/apache/flink/commit/e95b347dda5233f22fb03e408f2aa521ff924996";>Flink
+ * interface removal commit.</a>
+ */
+public interface BeamStoppableFunction extends StoppableFunction {}
Review comment:
>Originally RichParallelSourceFunction was implementing StoppableFunction,
which was removed as of Flink 1.9., so the following code wouldn't compile:
Actually, I just checked this again in Flink. `StoppableFunction` always has
been optionally. It was not implemented by `RichParallelSourceFunction`. The
only place where we use it in Beam is in `UnboundedSourceWrapper`. Like you
also suggested, I'd remove the stop implementation because it does not allow
for a more graceful stop than cancel. This simplifies the setup here and in any
case this will be broken in 1.9, so good to also make this change in Beam now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 325604)
Time Spent: 5h 10m (was: 5h)
> Add Flink 1.9 build target and Make FlinkRunner compatible with Flink 1.9
> -------------------------------------------------------------------------
>
> Key: BEAM-7730
> URL: https://issues.apache.org/jira/browse/BEAM-7730
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: sunjincheng
> Assignee: David Moravek
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Apache Flink 1.9 will coming and it's better to add Flink 1.9 build target
> and make Flink Runner compatible with Flink 1.9.
> I will add the brief changes after the Flink 1.9.0 released.
> And I appreciate it if you can leave your suggestions or comments!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
