[ 
https://issues.apache.org/jira/browse/BEAM-7939?focusedWorklogId=325801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325801
 ]

ASF GitHub Bot logged work on BEAM-7939:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Oct/19 16:20
            Start Date: 09/Oct/19 16:20
    Worklog Time Spent: 10m 
      Work Description: soyrice commented on issue #9306: [BEAM-7939] ZetaSQL 
dialect documentation
URL: https://github.com/apache/beam/pull/9306#issuecomment-540076471
 
 
   > My high level comment is this: I find the titles "Beam SQL lexical 
structure (Calcite)" and "Beam SQL Lexical Structure (ZetaSQL)" a bit 
confusing. I would rather lead with the dialect on the titles for those pages. 
I'm not sure what would improve it, but "Beam Calcite SQL Lexical structure" 
and "Beam ZetaSQL Lexical Structure" are a little better (but not nice on the 
eyes).
   > 
   > Ditto "Beam SQL operators for ZetaSQL" where I would rather say "Operators 
(Beam ZetaSQL)" or "Operators in Beam ZetaSQL" or "ZetaSQL operators supported 
by Beam ZetaSQL" or some such.
   > 
   > If I summarize the above into a single rule, it would be that once you are 
talking about a dialect, don't use the term "Beam SQL" any more.
   
   SGTM. I like "Beam Calcite" and "Beam ZetaSQL" as shorthands. Will implement 
this accordingly
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 325801)
    Time Spent: 1h 50m  (was: 1h 40m)

> Document ZetaSQL dialect in Beam SQL
> ------------------------------------
>
>                 Key: BEAM-7939
>                 URL: https://issues.apache.org/jira/browse/BEAM-7939
>             Project: Beam
>          Issue Type: Improvement
>          Components: website
>            Reporter: Cyrus Maden
>            Assignee: Cyrus Maden
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Blocked by BEAM-7832. ZetaSQL dialect source will be merged from #9210.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to