[
https://issues.apache.org/jira/browse/BEAM-8281?focusedWorklogId=327778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327778
]
ASF GitHub Bot logged work on BEAM-8281:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/19 12:02
Start Date: 14/Oct/19 12:02
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #9638: [BEAM-8281]
Resize IOITs datasets
URL: https://github.com/apache/beam/pull/9638#discussion_r334416029
##########
File path:
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/common/FileBasedIOITHelper.java
##########
@@ -45,15 +43,53 @@ public static String appendTimestampSuffix(String text) {
return String.format("%s_%s", text, new Date().getTime());
}
- public static String getExpectedHashForLineCount(int lineCount) {
- Map<Integer, String> expectedHashes =
- ImmutableMap.of(
- 1000, "8604c70b43405ef9803cb49b77235ea2",
- 100_000, "4c8bb3b99dcc59459b20fefba400d446",
- 1_000_000, "9796db06e7a7960f974d5a91164afff1",
- 100_000_000, "6ce05f456e2fdc846ded2abd0ec1de95");
+ public static IOTestConfig getTestConfigurationForConfigName(ConfigName
name) {
Review comment:
I think this method should be stored in a place common for all IOITs, not
only file-based ones. Perhaps we should move it to `IOTestConfig` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 327778)
Time Spent: 50m (was: 40m)
> Resize file-based IOITs
> ------------------------
>
> Key: BEAM-8281
> URL: https://issues.apache.org/jira/browse/BEAM-8281
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Resize the IOITs to use known amounts of data saved on GCS so that it's
> possible to report dataset size and measure throughput as part of the test
> metrics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
